Skip to content

Tests: uncover a quirk in our linkcheck tests#13466

Closed
jayaddison wants to merge 1 commit intosphinx-doc:masterfrom
jayaddison:pr-13452-followup/update-linkcheck-tests
Closed

Tests: uncover a quirk in our linkcheck tests#13466
jayaddison wants to merge 1 commit intosphinx-doc:masterfrom
jayaddison:pr-13452-followup/update-linkcheck-tests

Conversation

@jayaddison
Copy link
Contributor

Purpose

This change only affects our test suite; it exposes a quirk in behaviour as a result of an event-based call to the compile_linkcheck_allowed_redirects method (a fairly self-descriptive method).

This is a limitation of our linkcheck testsuite; some test cases may unwittingly rely on the compilation step.

Had this compilation been in place - reflecting how a sphinx-build -b linkcheck ... session would usually proceed -- then tests would have begun failing with the merge of #13452.

I think it suggests an unexpected change-in-default behaviour; confirming that tests fail for this PR could help to demonstrate the problem and discuss it.

References

@jayaddison
Copy link
Contributor Author

Obsoleted-by / included-in #13483.

@jayaddison jayaddison closed this May 7, 2025
@jayaddison jayaddison deleted the pr-13452-followup/update-linkcheck-tests branch May 7, 2025 09:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant